Re: [PATCH V4] POWER: perf_event: Skip updating kernel counters ifregister value shrinks

[Eric B Munson]

On Wed, 27 Apr 2011, David Laight wrote:

>  
> > +	if (prev > val && (prev - val) < 256)
> > +		delta = 0;
> > +
> > +	return delta;
> 
> Also, 'prev' is a true 64bit value, but 'val' is only ever 32bits.
> So once the 64bit 'prev' exceeds 2^32+256 both 'prev > val'
> and 'prev - val' are true regardless of the value of 'val'.
> This will lead to jumps in the value ....

prev and val are both 64 bit variables holding 32 bit numbers, we do not
accumulate in either, they are both replaced by values directly from the
registers.  So prev > val will not always be true.

Eric

Attachment: signature.asc
Description: Digital signature