Re: [PATCH] kconfig: Avoid buffer underrun in choice input

[Ben Hutchings]

On Wed, 2011-04-27 at 13:19 +0200, Michal Marek wrote:
> On 23.4.2011 19:42, Ben Hutchings wrote:
> > commit 40aee729b350672c2550640622416a855e27938f ('kconfig: fix default
> > value for choice input') fixed some cases where kconfig would select
> > the wrong option from a choice with a single valid option and thus
> > enter an infinite loop.
> >
> > However, this broke the test for user input of the form 'N?', because
> > when kconfig selects the single valid option the input is zero-length
> > and the test will read the byte before the input buffer.  If this
> > happens to contain '?' (as it will in a mips build on Debian unstable
> > today) then kconfig again enters an infinite loop.
> >
> > Signed-off-by: Ben Hutchings<ben@xxxxxxxxxxxxxxx>
> > Cc: stable@xxxxxxxxxx [2.6.17+]
> > ---
> > Roman has failed to respond to this after 5 weeks and one reminder, so
> > please take it directly.
> 
> I applied this on 8th April, see
> http://www.spinics.net/lists/linux-kbuild/msg04431.html.

Sorry, I forgot that.

> Please check 
> linux-next before reposting patches next time, now I either have to 
> rewind the kconfig branch or let Linus merge it with a duplicate commit :-(.

But the fix belongs in this release (2.6.39), not the next.  So I looked
in Linus' tree.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part