Re: [PATCH v3.2] kbuild: implement several W= levels
From: Sam Ravnborg
Date: Wed Apr 27 2011 - 16:46:48 EST
On Wed, Apr 27, 2011 at 10:15:27PM +0200, Borislav Petkov wrote:
> From: Sam Ravnborg <sam@xxxxxxxxxxxx>
>
> Building a kernel with "make W=1" produces far too much noise to be
> useful.
>
> Divide the warning options in three groups:
>
> W=1 - warnings that may be relevant and does not occur too often
> W=2 - warnings that occur quite often but may still be relevant
> W=3 - the more obscure warnings, can most likely be ignored
>
> When building the whole kernel, those levels produce:
>
> W=1 - 4859 warnings
> W=2 - 1394 warnings
> W=3 - 86666 warnings
>
> respectively. Warnings have been counted with Geert's script at
>
> http://www.kernel.org/pub/linux/kernel/people/geert/linux-log/linux-log-summary.pl
>
> Many warnings occur from .h files so fixing one file may have a nice
> effect on the total number of warnings.
>
> With these changes I am actually tempted to try W=1 now and then.
> Previously there was just too much noise.
>
> Borislav:
>
> - make the W= levels exclusive
> - move very noisy and making little sense for the kernel warnings to W=3
> - drop -Woverlength-strings due to useless warning message
> - copy explanatory text for the different warning levels to 'make help'
> - recount warnings per level
>
> Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Signed-off-by: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Dave Jones <davej@xxxxxxxxxx>
> Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
Looks good. Michal - please apply.
Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/