Re: [PATCH 2/3] make new alloc_pages_exact()

From: Dave Hansen
Date: Thu Apr 28 2011 - 12:03:13 EST


On Wed, 2011-04-27 at 16:42 -0500, Timur Tabi wrote:
> Dave Hansen wrote:
> >> Is there an easy way to verify that alloc_pages_exact(5MB) really does allocate
> >> > only 5MB and not 8MB?
>
> > I'm not sure why you're asking. How do we know that the _normal_
> > allocator only gives us 4k when we ask for 4k? Well, that's just how it
> > works. If alloc_pages_exact() returns success, you know it's got the
> > amount of memory that you asked for, and only that plus a bit of masking
> > for page alignment.
> >
> > Have you seen alloc_pages_exact() behaving in some other way?
>
> I've never tested this part of alloc_pages_exact(), even when I wrote (the first
> version of) it. I just took it on faith that it actually did what it was
> supposed to do.

I did actually go add a bunch of printks to it at one point. It did
seem to be working just fine and freeing the right amount of memory.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/