Re: [LinuxPPS] [PATCH 2/2] pps: new client driver using IRQs

[Alexander Gordeev]

Ð Fri, 29 Apr 2011 00:55:24 +0400
Alexander Gordeev <lasaine@xxxxxxxxxxxxx> ÐÐÑÐÑ:

> Ð Thu, 28 Apr 2011 16:03:59 -0400
> James Nuss <jamesnuss@xxxxxxxxxxxxxx> ÐÐÑÐÑ:
> 
> > Hi Alexander,
> > 
> > Thanks for reviewing the code.
> > 
> > On Thu, Apr 28, 2011 at 7:22 AM, Alexander Gordeev
> > <lasaine@xxxxxxxxxxxxx> wrote:
> > > Hi James,
> > >
> > > Ð Wed, 27 Apr 2011 14:14:14 -0400
> > > James Nuss <jamesnuss@xxxxxxxxxxxxxx> ÐÐÑÐÑ:
> > >
> > >> + Â Â Â Â Â Â return -EINVAL;
> > >> + Â Â }
> > >> +
> > >> + Â Â res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> > >> + Â Â if (res == NULL) {
> > >> + Â Â Â Â Â Â pr_err(PPS_IRQ_NAME ": no IRQ resource was given");
> > >> + Â Â Â Â Â Â return -EINVAL;
> > >> + Â Â }
> > >> +
> > >> + Â Â if (!(res->flags & (IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING))) {
> > >> + Â Â Â Â Â Â pr_err(PPS_IRQ_NAME ": given IRQ resource must be edge triggered");
> > >> + Â Â Â Â Â Â return -EINVAL;
> > >> + Â Â }
> > >
> > > I think it doesn't actually expect that both flags are set because it
> > > always treats it as assert in the irq handler. What does your signal
> > > look like?
> > 
> > The conditional logic is that one of either IRQF_TRIGGER_RISING or
> > IRQF_TRIGGER_FALLING must be set. It doesn't make much sense to have
> > neither set for PPS signals.
> > My intention is that the driver is generic enough so you can register
> > an IRQ resource with either IRQF_TRIGGER_RISING or
> > IRQF_TRIGGER_FALLING and you will get and assert event for that edge.
> > Clear events are not generated as you suggest but I believe this is
> > OK.
> > My signal is a simple low-to-high transition indicating the PPS. But I
> > believe you could register a device using this driver referencing the
> > other edge if required.
> 
> Ok, but is there a way one can register an IRQ resource with both flags
> set? If yes, then it would be nice to have a stricter check here to
> prevent two situations:
> 1. none flag is set (it is already in place)
> 2. both flags are set
> 
> The latter will definitely mess things up, right?

I mean, one surely can register an IRQ resource with both flags set. And
if the underlying hardware works as it is described (i.e. raises an irq
on both edges) then it will be a problem.

-- 
  Alexander

Attachment: signature.asc
Description: PGP signature