Re: [PATCH] audio: tlv320aic26: fix PLL register configuration

[Mike Williamson]

On Thu, Apr 28, 2011 at 5:56 PM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, Apr 28, 2011 at 05:32:57PM -0400, Michael Williamson wrote:
>
>> - Â Â jval = (fsref == 44100) ? 7 : 8;
>> - Â Â dval = (fsref == 44100) ? 5264 : 1920;
>> + Â Â jval = fsref / (aic26->mclk / 2048);
>> + Â Â dval = fsref - jval * (aic26->mclk / 2048);
>
> I'd like some more brackets on this line, especially given the
> similarity with the previous line. ÂOtherwise this looks fine if a bit
> magic:

I will add some parens (and comment the magic?) and resubmit with your ack.

Thanks.

>
> Acked-by: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/