Re: [PATCH 04/23] sched: Change NODE sched_domain group creation
From: Andreas Herrmann
Date: Fri Apr 29 2011 - 10:10:37 EST
On Thu, Apr 07, 2011 at 08:09:45AM -0400, Peter Zijlstra wrote:
> The NODE sched_domain is 'special' in that it allocates sched_groups
> per CPU, instead of sharing the sched_groups between all CPUs.
>
> While this might have some benefits on large NUMA and avoid remote
> memory accesses when iterating the sched_groups, this does break
> current code that assumes sched_groups are shared between all
> sched_domains (since the dynamic cpu_power patches).
>
> So refactor the NODE groups to behave like all other groups.
>
> (The ALLNODES domain again shared its groups across the CPUs for some
> reason).
>
> If someone does measure a performance decrease due to this change we
[...]
Will do some performance sniff tests to check this.
Andreas
--
Operating | Advanced Micro Devices GmbH
System | Einsteinring 24, 85609 Dornach b. München, Germany
Research | Geschäftsführer: Alberto Bozzo, Andrew Bowd
Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München
(OSRC) | Registergericht München, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/