Re: [PATCH] Subject: [PATCH] x86, AMD: K8 Rev.A-E processors aresubject to erratum 400

From: Boris Ostrovsky
Date: Fri Apr 29 2011 - 16:13:59 EST


On 04/29/2011 03:55 PM, Ingo Molnar wrote:

* Boris Ostrovsky<ostr@xxxxxxxxx> wrote:

Signed-off-by: Boris Ostrovsky<Boris.Ostrovsky@xxxxxxx>
Acked-by: Borislav Petkov<borislav.petkov@xxxxxxx>
Reported-by: Joerg-Volker Peetz<jvpeetz@xxxxxx>
Tested-by: Joerg-Volker Peetz<jvpeetz@xxxxxx>

Older AMD K8 processors (Revisions A-E) are affected by erratum 400 (APIC
timer interrupts don't occur in C states greater than C1). This, for example,
means that X86_FEATURE_ARAT flag should not be set for these parts.

This addresses regression introduced by commit
b87cf80af3ba4b4c008b4face3c68d604e1715c6 (x86, AMD: Set ARAT feature on AMD
processors") so it is somewhat high priority.

Hm, what is the regression, how do users see it? Hangs? Delays? Crashes?
Something more benign? The changelog should really contain such information.


The system becomes unresponsive until an external interrupt (e.g. keyboard input) happens. The most obvious effect is that time is not reported correctly. We haven't seen anything worse but that's probably bad enough.

Do you want me to resubmit the patch with updated comments?

Thanks.
-boris

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/