Re: [PATCH V4] tty/serial: add support for Xilinx PS UART

[johnlinn]

> On Wed, Apr 27, 2011 at 12:17:36PM -0600, johnlinn@xxxxxxxxxxx wrote:
> > From: John Linn <john.linn@xxxxxxxxxx>
> > 
> > The Xilinx PS Uart is used on the new ARM based SoC. This
> > UART is not compatible with others such that a seperate
> > driver is required.
> > 
> > Signed-off-by: John Linn <john.linn@xxxxxxxxxx>
> 
> I get build failures with this patch:
> 
>   CC [M]  drivers/tty/serial/xilinx_uartps.o
> drivers/tty/serial/xilinx_uartps.c: In function âxuartps_get_portâ:
> drivers/tty/serial/xilinx_uartps.c:785:14: error: âNO_IRQâ undeclared
> (first use in this function)
> drivers/tty/serial/xilinx_uartps.c:785:14: note: each undeclared
> identifier is reported only once for each function it appears in
> make[1]: *** [drivers/tty/serial/xilinx_uartps.o] Error 1
> 
> Care to fix this up so it's in a state I can properly apply it to the
> tree?
> 
> thanks,
> 
> greg k-h

Done and sent out as V5 of patch.

Just for future reference (and maybe I should know this).  How should I 
have prevented this problem? I guess I would need to build the kernel 
for other architectures and I don't normally do that.

Thanks,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/