Re: [tip:timers/core] time: Add timekeeping_inject_sleeptime

From: Thomas Gleixner
Date: Fri Apr 29 2011 - 20:24:23 EST


On Fri, 29 Apr 2011, Arve Hjønnevåg wrote:
> On Fri, Apr 29, 2011 at 10:31 AM, tip-bot for John Stultz
> <john.stultz@xxxxxxxxxx> wrote:
> > -       set_normalized_timespec(&time,
> > -                               newtime + delta.tv_sec,
> > -                               (NSEC_PER_SEC >> 1) + delta.tv_nsec);
> > -       do_settimeofday(&time);
> > +       /* subtract kernel time between rtc_suspend to rtc_resume */
> > +       time = timespec_sub(time, timespec_sub(newts, oldts));
>
> The delta you got from the rtc can be almost a second to long or
> short. Do you do anything to prevent these errors from accumulating?

By using the the magic crystal ball to avoid it or what do you have in
mind ?

Thanks,

tglx