Re: [PATCH 03/25] x86-64, NUMA: simplify nodedata allocation

[Tejun Heo]

On Fri, Apr 29, 2011 at 10:23:27AM -0700, Yinghai Lu wrote:
> On 04/29/2011 08:28 AM, Tejun Heo wrote:
> > With top-down memblock allocation, the allocation range limits in
> > ealry_node_mem() can be simplified - try node-local first, then any
> > node but in any case don't allocate below DMA limit.
> > 
> > Remove early_node_mem() and implement simplified allocation directly
> > in setup_node_bootmem().
> 
> keep early_node_mem would be better?

I don't know, maybe, maybe not.  I usually find separating out linear
procedural logic into a function, which is used only once, more
distracting / obfuscating than helpful.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/