Re: [PATCH] x86, NUMA: Fix empty memblk detection innuma_cleanup_meminfo()

[Tejun Heo]

On Sat, Apr 30, 2011 at 02:33:30PM +0200, Tejun Heo wrote:
> From: Yinghai Lu <yinghai@xxxxxxxxxx>
> 
> numa_cleanup_meminfo() trims each memblk between low (0) and high
> (max_pfn) limits and discard empty ones.  However, the emptiness
> detection incorrectly used equality test.  If the start of a memblk is
> higher than max_pfn, it is empty but fails the equality test and
> doesn't get discarded.
> 
> Fix it by using >= instead of ==.
> 
> Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> ---
> So, something like this.  Does this fix the problem you see?

Ooh, this is before the code is moved to numa.c, so please test the
previous patch against numa.c.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/