Re: [PATCH 001/001]: USB: cdc_acm: Fix oops when Droids MuIn LCD isconnected

[Greg KH]

On Wed, May 11, 2011 at 12:06:55PM +0200, Erik Slagter wrote:
> From: Erik Slagter <erik@xxxxxxxxxxxx>
> 
> The Droids MuIn LCD operates like a serial remote terminal.
> Data received are displayed directly on the LCD. This patch
> fixes the kernel null pointer oops when it is plugged in.
> 
> Add NO_DATA_INTERFACE quirk to tell the driver that "control"
> and "data" interfaces are not separated for this device, which
> prevents dereferencing a null pointer in the device probe code.
> 
> Signed-off-by: Erik Slagter <erik@xxxxxxxxxxxx>
> Signed-off-by: Maxin B. John <maxin.john@xxxxxxxxx>
> Tested-by: Erik Slagter <erik@xxxxxxxxxxxx>
> ---
> This patch applies to vanilla kernel 2.6.38.2, but I am quite
> confident it will apply to any recent kernel. It was created by
> Maxin John after I located the problem, slightly modified by me
> and tested by me, so blame me if it breaks anything.

If Maxin created it, it should have his "From:" on the top, right?

And did Maxin really sign-off-by: on the patch?  You can not add other
people's names to that without them really doing it, that's not allowed
at all.

Care to redo it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/