Re: [PATCH] sched: fix constructing the span cpu mask of sched domain

From: Ingo Molnar
Date: Wed May 11 2011 - 13:08:24 EST



* Hillf Danton <dhillf@xxxxxxxxx> wrote:

> On Wed, May 11, 2011 at 9:54 PM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > On Wed, 2011-05-11 at 21:26 +0800, Hillf Danton wrote:
> >> Your work for rewriting NUMA support, published at
> >>          http://marc.info/?l=linux-kernel&m=130218515520540
> >> is patched by changing how level is computed and by changing how it is
> >> used to build the mask.
> >>
> >> When computing, some valid levels are lost in your work.
> >>
> >> When building mask, nodes are selected only if they have same distance,
> >> thus nodes of less distance are also masked out since the computation of
> >> level now is tough.
> >>
> >> Without MUNA hardware, I did not test the patch:(
> >
> > I do have a (tiny) NUMA box (2 nodes) but that actually booted with the
> > old code too, Andreas Hermann from AMD (CC'ed) is usually willing to
> > test such patches on somewhat larger systems. Please send a full patch
> > against tip/master for him to apply.
> >
> Oh my God, I am not good at playing game with git, already laughed by many
> guys on LKML. As you see, I delivered all works based on diff through 512K ADSL,
> things like "git clone" sounds really monstrous.
>
> Would you please, Peter, teach me how to play git, since I want to do more?

Here's how you fetch the scheduler tree:

http://people.redhat.com/mingo/tip.git/README

and here's the Kernel Hacker's Guide to Git:

http://linux.yyz.us/git-howto.html

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/