Re: [PATCH] perf: export power_start and power_end tracepoints

[Ingo Molnar]

* Jean Pihet <jean.pihet@xxxxxxxxxxxxxx> wrote:

> Adding l-o and linux-pm MLs. The original post is at
> http://www.spinics.net/lists/kernel/msg1186554.html
> 
> On Fri, May 13, 2011 at 4:48 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > * jean.pihet@xxxxxxxxxxxxxx <jean.pihet@xxxxxxxxxxxxxx> wrote:
> >
> >> From: Jean Pihet <j-pihet@xxxxxx>
> >>
> >> If used in a module both tracepoints need to be exported by the
> >> kernel.
> >
> > but it's not used by any module in the kernel AFAICS, so why is this needed?
> Not currently, that is why the error went unnoticed. I think it is
> better to fix it now than later.
> 
> I am working on a plan to clean-up and isolate the OMAP PM code from
> the core code and to provide the PM functionality as a module. This
> effort is part of the 'remove the crazy ARM churn' from the kernel.

Feel free to keep this patch with those modifications/cleanups:

Acked-by: Ingo Molnar <mingo@xxxxxxx>

but please make sure you push it together, i.e. never export something 
(knowingly) without having in-tree use for it.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/