Re: [PATCH] ARM: twd: Adjust localtimer frequencywithcpufreqnotifiers

From: Thomas Gleixner
Date: Mon May 16 2011 - 10:44:29 EST


On Mon, 16 May 2011, Santosh Shilimkar wrote:
> On 5/14/2011 9:21 PM, Thomas Gleixner wrote:
> Just for my understanding, the clockevents_reconfigure() needs to
> be called with interrupts disabled on that CPU as part of
> the CPUFREQ notifiers. I assume the right place is do it
> in POST notifier after the CPU clock and hence TWD clock is
> updated. Is that right ?

Yes.

> Since there is need to call this API in interrupt
> disable context, does it make sense to take care of it
> inside the API itself instead of relying on caller fn ?

Hmm, no strong opinion

> The arch's where the per CPU TWD's share clock, per-cpu
> clock-events should be reconfigured on all CPUs, whenever
> the parent(CPU) clock has changed using some thing like
> smp_call_function_any() etc. Is that right understanding?

Yes. If that's a common requirement we should move that to core code.

Thanks,

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/