Re: [PATCH 3/3] checkpatch.pl: Add check for task comm references

[Michal Nazarewicz]

On Tue, 17 May 2011 01:04:50 +0200, Joe Perches <joe@xxxxxxxxxxx> wrote:

> On Mon, 2011-05-16 at 14:34 -0700, David Rientjes wrote:
> > On Mon, 16 May 2011, Michal Nazarewicz wrote:
> > > > Now that accessing current->comm needs to be protected,
> > > > +# check for current->comm usage
> > > > +		if ($line =~ /\b(?:current|task|tsk|t)\s*->\s*comm\b/) {
> > > Not a checkpatch.pl expert but as far as I'm concerned, that looks  
> > reasonable.
>
> I think the only checkpatch expert is Andy Whitcroft.
>
> You don't need (?: just (

Yep, it's a micro-optimisation though.

--
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/