Re: [PATCH] dw_dmac: Replace subsys_init() with arch_initcall()

[viresh kumar]

On 05/16/2011 09:36 PM, Koul, Vinod wrote:
> On Mon, 2011-05-16 at 10:20 +0530, Viresh Kumar wrote:
>> In some cases users of dw_dmac, amba-pl022, are initialized before dw_dmac, and
>> if they try to use dw_dmac, they simply fail. So its better we register init()
>> routine of driver using arch_initcall() instead of subsys_init(), so that dma
>> driver is available at the earliest possible.
>>
>> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxx>
>> ---
>>  drivers/dma/dw_dmac.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
>> index 54d72a8..4b580e7 100644
>> --- a/drivers/dma/dw_dmac.c
>> +++ b/drivers/dma/dw_dmac.c
>> @@ -1566,7 +1566,7 @@ static int __init dw_init(void)
>>  {
>>  	return platform_driver_probe(&dw_driver, dw_probe);
>>  }
>> -subsys_initcall(dw_init);
>> +arch_initcall(dw_init);
> arch_init is usually kept for subystem initialization.
> Why cant you move the amba-pl022 init to module_init, that should take
> care of this.
> 

Actually, amba-pl022 init was moved to subsys_initcall earlier with
following patch:

commit 25c8e03bdb769dfe2381f8b7942f05b0eb4bdf31
Author: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
Date:   Mon Sep 6 11:02:12 2010 +0200

    spi/pl022: move probe call to subsys_initcall()
    
    The PL022 SPI bus is sometimes used for early stuff like
    regulators that need to be present at module_init() time, so
    we move this to a subsys_initcall().
    
    Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
    Signed-off-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
---
 drivers/spi/amba-pl022.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

And so i moved dma's init to arch_initcall. Also the similar approach is
taken by drivers/dma/ste_dma40.c

Also, maybe it makes more sense for dma to be up at the earliest.
Isn't it?

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/