Re: [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations

[Mohan Pallaka]

 On 5/15/2011 4:28 PM, Russell King - ARM Linux wrote:
> On Sun, May 15, 2011 at 01:00:31AM -0700, Dmitry Torokhov wrote:
> > On Fri, May 13, 2011 at 06:13:21PM +0530, Mohan Pallaka wrote:
> > > For chip drivers that support both pwm and non-pwm modes
> > > would encounter compilation errors if the platform doesn't
> > > have support for pwm though the chip is programmed to work
> > > in non-pwm mode. Add __weak attributed pwm functions to avoid
> > > compilation issues in these scenarios.
> > Russell,
> >
> > You seem to have authored pwm.h, do you have any objections to this
> > change?
> This seems to be a recipe for an oops.  Have a look at how
> linux/regulator/consumer.h deals with this kind of problem, and notice
> that we have CONFIG_HAVE_PWM to indicate whether this interface is
> supported or not.
Thanks for the suggestion. I'll upload a new patch.

--Mohan.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/