Re: [PATCH] sched: fix priority leakage in pick_next_highest_task_rt()

[Yong Zhang]

On Tue, May 17, 2011 at 10:53 PM, Hillf Danton <dhillf@xxxxxxxxx> wrote:
> On Tue, May 17, 2011 at 10:28 AM, Yong Zhang <yong.zhang0@xxxxxxxxx> wrote:
>> On Mon, May 16, 2011 at 8:55 PM, Hillf Danton <dhillf@xxxxxxxxx> wrote:
>>> When picking the second highest RT task for a given runqueue, if no
>>> task found after scanning the queue of priority == idx, the next idx
>>> should also be checked even in case that next is already existing, or
>>> the window of priority leakage could be opened.
>>
>> I don't see what kind of problem you patch will fix.
>> And mind explaining how priority leakage could happen?
>>
> Hi Yong
>
> If no task is found after scanning the list at array->queue + idx,
> what should we operate on next?
> And why is the list scanned?

Hmmm, I get your point.

Reviewed-by: Yong Zhang <yong.zhang0@xxxxxxxxx>

Thanks,
Yong



-- 
Only stand for myself
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/