Re: [PATCH 1/3][STAGING SM7XX-cleanup-resend]:removing extraspaces,redundant code and using macros

[Greg KH]

On Wed, May 18, 2011 at 08:41:32AM +0530, anish singh wrote:
> Hi Greg,
>  
> Resending all the 3 patches.
> Subject line:
> [PATCH 1/3][STAGING SM7XX-cleanup-resend]:removing extra spaces,redundant code
> and using macros
> [PATCH 2/3][STAGING SM7XX-cleanup-resend]:preferred form for passing a size to
> memory allocation routines
> [PATCH 3/3][STAGING SM7XX-cleanup-resend]:printk loglevels modified to match
> the scenario

This does not belong in the 1/3 patch, and neither does that extra
information in the [].

Your patches should look like:
	[PATCH 1/3] Staging: sm7xx: remove extra whitespace
and the like.

> This patch is to remove extra spaces,redundant code and using
>  ARRAY_SIZE macros.
>  Signed-off-by: anish kumar<anish198519851985@xxxxxxxxx>

You need an extra line before the Signed-off-by: line.

And an extra space after your name and before the '<'

Care to try it all again?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/