Re: [PATCH 6/7] tty/powerpc: introduce the ePAPR embedded hypervisorbyte channel driver

From: Greg KH
Date: Thu May 19 2011 - 10:22:39 EST


On Thu, May 19, 2011 at 08:54:31AM -0500, Timur Tabi wrote:
> +/*
> + * The udbg subsystem calls this function to display a single character.
> + * We convert CR to a CR/LF.
> + */
> +static void ehv_bc_udbg_putc(char c)
> +{
> + if (c == '\n')
> + byte_channel_spin_send('\r');
> +
> + byte_channel_spin_send(c);
> +}

Why do this conversion in the driver? Shouldn't that be something that
userspace worries about?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/