Re: [PATCH 09/10] ptrace: add JOBCTL_BLOCK_NOTIFY

[Oleg Nesterov]

On 05/19, Tejun Heo wrote:
>
> Hello,
>
> On Thu, May 19, 2011 at 06:32:33PM +0200, Oleg Nesterov wrote:
> > > +	/*
> > > +	 * Make sure @chlid is still ptraced by us and clear BLOCK_NOTIFY.
> > > +	 */
> > > +	if (likely((child->ptrace & PT_PTRACED) && child->parent == current))
> >
> > This looks a bit confusing... It is either traced or not. If it is traced,
> > nobody else can trace it. In fact even PT_PTRACED is not strictly needed
> > but I agree this check makes the code cleaner.
>
> Hmmm... I suppose we can make the error paths finer grained so that
> attach failure

Ah, you are right again, I forgot about PTRACE_ATTACH path.

Thanks,

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/