RE: [PATCH] drivers: create a pinmux subsystem v2

[Stephen Warren]

Linus Walleij wrote at Tuesday, May 17, 2011 11:57 PM:
> 2011/5/18 Stephen Warren <swarren@xxxxxxxxxx>:
> 
> >> +static struct foo_pmx_func myfuncs[] = {
> >> +     {
> >> +             .name = "spi0-0",
> >> +             .pins = spi0_0_pins,
> >> +             .num_pins = ARRAY_SIZE(spi0_1_pins),
> >> +     },
> >> ...
> >
> > Rather than defining a custom type (foo_pmx_func) for this array inside
> > each driver, and then having to implement _list, _get_fname, _get_pins
> > below, how about:
> >
> > * pinmux core defines a basic structure containing all the information
> >  that the core needs from the specific implementation.
> >
> > ...
> > static struct foo_pmx_func spi0_0_func = {
> >        FOO_REG_PMX_A,
> >        0x30,
> >        0x10,
> > };
> > ...
> > static struct pinmux_function myfuncs[] = {
> >        {
> >                .name = "spi0-0",
> >                .pins = spi0_0_pins,
> >                .num_pins = ARRAY_SIZE(spi0_1_pins),
> >                .driver_data = &spi0_0_func,
> >        },
> > ...
> >
> > This would remove some boiler-plate code from the SoC drivers,
> > although it might be considered a bad breaking of abstraction barriers?
> 
> Yes it does, however I didn't want to make the initial submission
> feature creepy. So I would like this to go in as is, then refactor
> drivers to get help from the framework later on, if we see that
> it is needed. (So the solution would evolve gradually rather
> than being too much designed-in from the beginning.)
> 
> Do you think the driver support functions are needed from start?
> I could do it I think...

Sorry for the slow responses.

I think this suggestion of mine isn't a big deal, so I'd basically be
OK going either way initially.

Still, if I was writing the patches, and I agreed with the above change,
I think I'd want to put it into the first patchset (or at least before
other people started implementing their pinmux drivers on top of the code)
since it'd avoid everyone else (or me) having to refactor all their
drivers almost immediately after writing them, plus it looks like a very
simple change to the current pinmux patchset.

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/