Re: [PATCH v2] signal: trivial, fix the "timespec declared insideparameter list" warning

[Mike Frysinger]

On Thu, May 19, 2011 at 14:19, Oleg Nesterov wrote:
> On 05/18, Andrew Morton wrote:
>> On Mon, 16 May 2011 14:57:29 +0200 Oleg Nesterov wrote:
>> > --- sigprocmask/include/linux/signal.h~15_stw_warning    2011-05-12 20:44:43.000000000 +0200
>> > +++ sigprocmask/include/linux/signal.h   Â2011-05-16 14:53:08.000000000 +0200
>> > @@ -234,6 +234,9 @@ static inline int valid_signal(unsigned
>> > Â Â return sig <= _NSIG ? 1 : 0;
>> > Â}
>> >
>> > +struct timespec;
>> > +struct pt_regs;
>> > +
>> > Âextern int next_signal(struct sigpending *pending, sigset_t *mask);
>> > Âextern int do_send_sig_info(int sig, struct siginfo *info,
>> > Â Â Â Â Â Â Â Â Â Â Â Â Â Â struct task_struct *p, bool group);
>>
>> Please put the forward declarations at top-of-file. ÂIn this case,
>> inside #ifdef __KERNEL__. ÂThis reduces the risk of accumulating
>> duplicated forward declarations, as has happened in the past.
>
> This is what Mike suggested from the very beginnig. Perhaps this
> would be better but since I already applied this patch... I'd prefer
> to not test my git skills, unless you or Mike object.

i'm ok with this version as it's at the top of the existing prototype
block.  Andrew's version also would work of course.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/