Re: [PATCH 1/3] ARM: mxs: remove gpio driver from mach-mxs

From: Shawn Guo
Date: Fri May 20 2011 - 06:22:40 EST


On Fri, May 20, 2011 at 12:04:59PM +0200, Arnd Bergmann wrote:
> On Friday 20 May 2011 11:57:24 Shawn Guo wrote:
> > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx>
> > ---
> > arch/arm/mach-mxs/Makefile | 2 +-
> > arch/arm/mach-mxs/gpio.c | 331 --------------------------------------
> > arch/arm/mach-mxs/gpio.h | 34 ----
> > arch/arm/mach-mxs/mach-mx28evk.c | 1 -
> > arch/arm/mach-mxs/mm-mx23.c | 1 -
> > arch/arm/mach-mxs/mm-mx28.c | 1 -
> > 6 files changed, 1 insertions(+), 369 deletions(-)
> > delete mode 100644 arch/arm/mach-mxs/gpio.c
> > delete mode 100644 arch/arm/mach-mxs/gpio.h
>
> The patch looks good (removing stuff often is), but
> you are missing a changelog. Please explain why it's
> not used any more so that people can find it later
> when they only look at git but not at your original
> mail 0/3 or the entire series.
>
That's right. Will do.

--
Regards,
Shawn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/