Re: [PATCH 0/7] overlay filesystem v9

From: Andy Whitcroft
Date: Fri May 20 2011 - 08:43:51 EST


On Fri, May 20, 2011 at 10:18:30AM +0200, Miklos Szeredi wrote:

> Yeah, it should probably do something like:
>
> if (inode->i_op->getattr) {
> struct kstat stat;
> inode->i_op->getattr(...)
> uid = stat.uid;
> } else {
> uid = inode->i_uid;
> }
>
> The problem is that getattr takes a vfsmount, which makes this
> impossible to do cleanly. And the solution is for ->getattr() to lose
> that argument, which is a bit more involved :(

Ok. I am going to take this as a bug in the LSM, so ignore my patch
here. I have been poking at what the LSM is doing and actually I think
I see the flaw, so I will take the issue up with them.

In light of that take this as a "tested heavily and it worked without
issues" on the V9 version.

Tested-by: Andy Whitcroft <apw@xxxxxxxxxxxxx>

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/