Re: [PATCH]: Fix Ultrastor asm snippet

From: Samuel Thibault
Date: Fri May 20 2011 - 09:04:25 EST


Christoph Hellwig, le Fri 20 May 2011 09:02:15 -0400, a écrit :
> On Wed, May 18, 2011 at 05:06:05PM +0200, Samuel Thibault wrote:
> > Commit 1292500b replaced
> >
> > "=m" (*field) : "1" (*field)
> >
> > with
> >
> > "=m" (*field) :
> >
> > with comment "The following patch fixes it by using the '+' operator on
> > the (*field) operand, marking it as read-write to gcc."
> > '+' was actually forgotten. This really puts it.
>
> Do you actually have the hardware or was this just a code audit?

Just a code audit.

> I have the strong suspicion that this driver is pretty much dead and
> bitrotting.

Most probably, yes.

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/