Re: [PATCH 02/10] mach-u300: rewrite gpio driver, move todrivers/gpio

[Jamie Iles]

On Fri, May 20, 2011 at 05:07:12PM -0500, H Hartley Sweeten wrote:
> On Thursday, May 19, 2011 6:50 PM, Jamie Iles wrote:
> > diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> > index becef59..aa9e97f 100644
> > --- a/drivers/gpio/Makefile
> > +++ b/drivers/gpio/Makefile
> > @@ -10,6 +10,7 @@ obj-$(CONFIG_GPIOLIB)         += gpiolib.o
> >  
> >  obj-$(CONFIG_GPIO_ADP5520)     += adp5520-gpio.o
> >  obj-$(CONFIG_GPIO_ADP5588)     += adp5588-gpio.o
> > +obj-$(CONFIG_GPIO_BASIC_MMIO_CORE)     += basic_mmio_gpio.o
> >  obj-$(CONFIG_GPIO_BASIC_MMIO)  += basic_mmio_gpio.o
> 
> I think the line above should be removed.  GPIO_BASIC_MMIO selects
> GPIO_BASIC_MMIO_CORE so the line you added previous to it will cause
> basic_mmio_gpio to be compiled.
> 
> GPIO_BASIC_MMIO is really just used in the driver to enable the code
> at the end which creates the generic gbpio_driver.

Yes, well spotted.  I'll create a patch to remove this.

Jamie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/