Re: [PATCH] kernel: Fix ftrace.c compiler warning when calling ftrace_nop_replace()

[H. Peter Anvin]

On 05/22/2011 06:19 PM, Eduardo Silva wrote:
> the function ftrace_nop_replace() returns a 'static const unsigned char *'
> value, so when the caller perform a direct assignment to a
> 'static unsigned char *', the compiler raise the following warning message:
> 
>  ftrace.c:308:6: warning: assignment discards qualifiers from pointer target type
>  ftrace.c:318:6: warning: assignment discards qualifiers from pointer target type
> 
> Adding the proper casts the message goes away.
> 
> Signed-off-by: Eduardo Silva <edsiper@xxxxxxxxx>

This quiets a warning of something that potentially looks like a real
bug.  Perhaps "new" should be const?

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/