question about blk_schedule_flush_plug

[Con Kolivas]

I was looking at the scheduler changes going into 2.6.39 again and wondered 
about the use of blk_schedule_flush_plug smack in the middle of schedule()

It looks like this:
			if (blk_needs_flush_plug(prev)) {
				raw_spin_unlock(&rq->lock);
				blk_schedule_flush_plug(prev);
				raw_spin_lock(&rq->lock);
			}

Now call me suspicious but to my eyes it looks really dubious unlocking the 
runqueue like that right in the heart of schedule().

Comments?

Thanks,
Con
-- 
-ck
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/