Re: [bloat] Measuring header file bloat effects on kernel buildperformance: a more than 2x slowdown ...

From: Ingo Molnar
Date: Mon May 23 2011 - 06:55:44 EST



* Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:

> On Mon, May 23, 2011 at 12:09 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
> >      24594a2bfcaa: [PATCH] x86-64 merge
> >
> >     - Remove some unneeded prefetches.  Just two are enough to kickstart
> >       the hardware prefetcher.
> >
> >   But despite touching prefetches explicitly, this too sloppily left the (now
> >   dangling) prefetch.h include file around.
>
> Well, developer removes include, developer risks compile breakage.

If developer removes the final prefetch() from an unrelated header he might as
well think of removing the prefetch.h header. If there's compile breakage we
want to fix the breakage.

But yes, this is easily forgotten and the basic psychology is for header file
dependencies to grow, almost never to shrink.

To counteract that in a really good way we need tooling help - we are fighting
entropy here ...

> > Anway, what i tried to demonstrate with this mail how much *real* slowdown
> > in the kernel build our current header file bloat is causing. We could
> > literally halve our kernel build times if we fixed this!
>
> News at 11!

I have not seen *actual hard numbers* measured before, so how exactly is this
news at 11? So i think your condescending reply is neither fair nor justified.

Yes, we all knew that there's build time costs of header bloat - but it was
never AFAIK measured and posted to lkml in such a clear way.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/