Re: ramoops: is using platform_drivers correct?

[Kyungmin Park]

Hi,

You have to define the ramoops platform data at your board file and
pass it to the platform device init.
As these address is different for each SoCs. e.g., x86, and Samsung
ARM SoCs and so on.

I think maybe you use the x86 so define the default x86 ram address
for ramoops and pass it to platform structures.

At office, I will send the sample usage.

Thank you,
Kyungmin Park

On Mon, May 23, 2011 at 11:10 PM, Américo Wang <xiyou.wangcong@xxxxxxxxx> wrote:
> On Mon, May 23, 2011 at 9:27 PM, Stevie Trujillo
> <stevie.trujillo@xxxxxxxxx> wrote:
>> Hello,
>>
>> ramoops (drivers/char/ramoops.c) is for "all" computers right? When I try to
>> load it on my laptop, I get ENODEV. This is caused by platform_driver_probe()
>> - the code never reaches the ramoops probe callback.
>>
>> After I removed the platform_driver stuff, moving everything into ramoops_init
>> and ramoops_exit it worked.
>
> Actually that was changed by Kyungmin, Cc'ing...
>
> commit c3b92ce9e75f6353104fc7f8e32fb9fdb2550ad0
> Author: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> Date:   Wed Oct 27 15:34:52 2010 -0700
>
>    ramoops: use the platform data structure instead of module params
>
>    As each board and system has different memory for ramoops.  It's better to
>    define the platform data instead of module params.
>
>    [akpm@xxxxxxxxxxxxxxxxxxxx: fix ramoops_remove() return type]
>    Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>    Cc: Marco Stornelli <marco.stornelli@xxxxxxxxx>
>    Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>    Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/