RE: [PATCH 1/1] Clocksource: Move the Hyper-V clocksource driverout of staging

[KY Srinivasan]

> -----Original Message-----
> From: Christoph Hellwig [mailto:hch@xxxxxxxxxxxxx]
> Sent: Monday, May 23, 2011 2:43 PM
> To: KY Srinivasan
> Cc: gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; tglx@xxxxxxxxxxxxx; johnstul@xxxxxxxxxx;
> hch@xxxxxxxxxxxxx; Hank Janssen; Haiyang Zhang
> Subject: Re: [PATCH 1/1] Clocksource: Move the Hyper-V clocksource driver out
> of staging
> 
> > +#include <linux/version.h>
> 
> This one shouldn't be needed.

Correct; I will fix this.
> 
> > +#include <asm/hyperv.h>
> > +#include <asm/mshyperv.h>
> 
> not really a review for this driver, but what's the purpose if having
> these two headers?

These header files have the defines for checking if we are running on 
Hyper-V.

> 
> Shouldn't the Kconfig entry also move from drivers/staging to
> arch/x86 towards the other clocksources?

Currently this driver is built if  HYPERV is defined. I agree with you
that I should have Kconfig entry in arch/x86. Since the rest of the 
Hyper-V drivers are still in staging, I am thinking that perhaps we should 
have a different config switch - HYPERV_CLKSRC. I will go ahead and 
spin a new version of this patch with this change.

Regards,

K. Y
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/