Re: [GIT PATCH] STAGING pull for .40

From: Linus Torvalds
Date: Mon May 23 2011 - 16:43:40 EST


On Mon, May 23, 2011 at 12:38 PM, Greg KH <greg@xxxxxxxxx> wrote:
> Here is the big pull request for the staging tree for your .40 tree (or
> 2.8.0, whatever you are wanting to rename it to.)

Hmm. Doing my once-a-release "try to compile everything in staging
after pulling from greg by using allyesconfig and also forcing all
staging", I get this:

drivers/staging/brcm80211/brcmsmac/built-in.o:(.data+0xba0):
multiple definition of `wl_msg_level'
drivers/staging/brcm80211/brcmfmac/built-in.o:(.data+0x1a94): first
defined here

which looks like another case of "can't compile two things both into
the kernel".

Looks like the BRCMSMAC / BRCMFMAC drivers need to be mutually
exclusive. Something like

depends on m || (BRCMSMAC != y)

for BRCMFMAC?

Or they should just avoid using the same globally visible name.

I dunno.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/