Re: [GIT PULL] more x86/apic changes for v2.6.40

[Ingo Molnar]

* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Mon, May 23, 2011 at 12:30 PM, Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > Please pull the latest x86-apic-for-linus git tree from:
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git x86-apic-for-linus
> 
> Hmm. Right now my bisect is going (and on that slow atom thing I'm
> just about to give up for the evening and continue tomorrow), but it
> *looks* like this pull breaks resume on my eeepc netbook.
> 
> I've bisected it down to three merges:
>  - sched-core-for-linus (looks unlikely)
>  - 'for-linus' of master.kernel.org:/home/rmk/linux-2.6-arm
>  - x86-apic-for-linus (I don't see anything wrong, but it seems to be
> the most likely of the three)
> 
> Any idea why anything there would break resume?

Possibly the resume fix in the APIC merge :-/

It's these commits:

 31dce14a3269: x86, ioapic: Use ioapic_saved_data while enabling intr-remapping
 4c79185cdb14: x86, ioapic: Allocate ioapic_saved_data early
 b64ce24daffb: x86, ioapic: Fix potential resume deadlock

The first one fixes the resume bug in an easily backportable way (although the 
GFP_ATOMIC is not nice), the later two do it cleaner.

So if b64ce24daffb works for you and 31dce14a3269 breaks this would signal that 
the fix from Suresh is the source of the Atom regression.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/