Re: [PATCH] sched: remove noop in next_prio()

[Yong Zhang]

On Sat, May 21, 2011 at 10:19 PM, Hillf Danton <dhillf@xxxxxxxxx> wrote:
> When computing the next priority for a given run-queue, the check for
> RT priority of the task determined by the pick_next_highest_task_rt()
> function could be removed, since only RT task is returned by the
> function.
>
> Signed-off-by: Hillf Danton <dhillf@xxxxxxxxx>

Yup, it's true.

Reviewed-by: Yong Zhang <yong.zhang0@xxxxxxxxx>

> ---
>
> --- a/kernel/sched_rt.c 2011-04-27 11:48:50.000000000 +0800
> +++ b/kernel/sched_rt.c 2011-05-21 22:10:34.000000000 +0800
> @@ -670,7 +670,7 @@ static inline int next_prio(struct rq *r
> Â{
> Â Â Â Âstruct task_struct *next = pick_next_highest_task_rt(rq, rq->cpu);
>
> - Â Â Â if (next && rt_prio(next->prio))
> + Â Â Â if (next)
> Â Â Â Â Â Â Â Âreturn next->prio;
> Â Â Â Âelse
> Â Â Â Â Â Â Â Âreturn MAX_RT_PRIO;
>



-- 
Only stand for myself
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/