Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd

[Felipe Balbi]

Hi,

On Tue, May 24, 2011 at 01:31:14PM +0300, Tanya Brokhman wrote:
> > but then again, maybe you changed driver->speed
> > to super and didn't provide superspeed descriptors.
> > 
> 
> Yes :) The driver->speed is updated in usb_composite_probe() if
> CONFIG_USB_GADGET_SUPERSPEED is defined.
> 
> So, are we ok with this solution? The module parameter I mean?
> Are you going to try the v13 in your branch? Please let me know how it goes
> and of course if you have any comments.

I think it still gives the possibility for failure. I would rather not
take that until all gadget drivers are fixed. We can help you doing that
and we only change driver->speed after all gadget drivers have their
"sensible defaults" SuperSpeed descriptors.

What do you say ? Other than that, the module parameter is, like Alan
Said, useful for debugging, so we might as well keep it.

-- 
balbi

Attachment: signature.asc
Description: Digital signature