Re: [PATCH v12 4/8] usb:gadget: Add SuperSpeed support to the Gadget Framework

[Mike Frysinger]

On Tue, May 24, 2011 at 01:37, Tanya Brokhman wrote:
>> > Mike answered that you're right in your observation. I'm not familiar
>> > with blackfin. Could you please elaborate on this? I understand that
>> > I need to use put_unaligned_le16(), will do, but I would like to better
>> > understand why and if there is a way to test this so that blackfin
>> > won't be broken.
>>
>> not all arches support unaligned accesses. Âor they do, but it's done
>> via (non-trivial) exception processing in software. Âreq->buf is of
>> type void* and so presumably is not guaranteed to be aligned on a 2
>> byte boundary.
>
> Thanks for the explanation, Mike! I'll update the patch.

also, for arches where unaligned accesses work (like x86), the
unaligned macros will simply expand to direct accesses like the code
you had originally.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/