Re: [PATCH 1/4] include/linux/printk.h is not self-contained

[Joe Perches]

On Wed, 2011-05-25 at 11:09 +0200, y@xxxxxxxxxxxx wrote:
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> <linux/printk.h> needs to include
>   - <stdarg.h> for "va_list",
>   - <linux/linkage.h> for "asmlinkage",
>   - <linux/types.h> for "bool".

I wonder if printk should be self-contained.

If so, this patch should also add:

#include <linux/dynamic_debug.h>
#include <linux/ratelimit.h>

If not, maybe add:

#ifndef _LINUX_KERNEL_H
#error don't include <linux/printk.h> directly, use <linux/kernel.h>
#endif

Also asmlinkage is an ancient artifact and should
be removed from the declarations of early_printk,
vprintk, and printk.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/