Re: [PATCH 1/3] x86, intel: Output microcode revision

[Borislav Petkov]

On Wed, May 25, 2011 at 07:28:52AM -0400, Ingo Molnar wrote:
> 
> * Borislav Petkov <bp@xxxxxxxxx> wrote:
> 
> > Btw, can we dump the ucode version in hex since ours are much easier to
> > read that way:
> > 
> > [86483.770976] microcode: CPU0: patch_level=0x010000c4
> > [86483.826987] microcode: CPU1: patch_level=0x010000c4
> > [86483.835071] microcode: CPU2: patch_level=0x010000c4
> > ...
> 
> How is that version constructed and iterated, or example is the 
> 0x01000000 bit always set?
> 
> If it's always set then it might make sense to turn this into a more 
> human-readable version number: mask out the 0x01000000 and report 
> 0xc4 as 194? Or is the *real* version above just '4'?
> 
> Should 0x010000c4 perhaps be printed as 1.10.4?

Nah, splitting this doesn't give you any information we could use,
besides this format is the only format our ucode nomenclature uses so
having it different in Linux might cause confusion.

> 
> > I guess for Intel the ucode version format won't matter that much.
> 
> Well, if Intel does similar encodings as AMD,

I hardly doubt that.

> then it would be nice to turn that into human-readable version strings
> as well.

I think leaving it as a hex number would fit both vendors adequately.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/