Re: [RFC][PATCH] ftrace: Add internal recursive checks

[Steven Rostedt]

On Thu, 2011-05-26 at 00:54 +0200, Thomas Gleixner wrote:
> On Wed, 25 May 2011, Steven Rostedt wrote:

> > Any user of the function tracer (callbacks) may need to do the same
> > thing, because the callbacks could be called without going though the
> > list lookup and may need their own bit set.
> 
> Errm, what means _MAY_? There are no users outside of kernel/trace/
> for this right now. Are you saying that you forgot to update some code
> or is this about random out of tree users?

Actually, I was thinking about perf, not some random out of tree user.
But if this is needed, I hate to have to move the code then. It's not
like it's modifying some internal to ftrace variable. It is modifying a
variable in the task_struct. If there are other users that need it. Why
not expose it in a core header? And it's not like ftrace.h is a bad
location for this. ftrace.h is in fact made for function tracing.

This would not even work for out of tree users, as any bit they chose,
could someday conflict with an internal user.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/