Re: [PATCH] crypto: sha1: modify sha1_update to use SHA1_BLOCK_SIZE

[David Miller]

From: Mandeep Singh Baines <msb@xxxxxxxxxxxx>
Date: Wed, 25 May 2011 20:11:17 -0700

> Plus some other minor cleanup.
> 
> Signed-off-by: Mandeep Singh Baines <msb@xxxxxxxxxxxx>

The temp[] buffer is explicitly places inside the inner most
basic block so that the compiler doesn't allocate the stack
space unless that code path is taken.

Besides the use of the SHA_* macros, I think your changes
actually make the code worse.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/