Re: [PATCH] drm/i915: fix regression after clock gating init split

[Keith Packard]

On Fri, 27 May 2011 23:44:19 +1000, Jason Stubbs <jasonbstubbs@xxxxxxxxx> wrote:
> From: Jason Stubbs <jasonbstubbs@xxxxxxxxx>
> 
> In revision 6067aaeadb5b3df26f27ac827256b1ef01e674f5, the function
> intel_enable_clock_gating is split up by device. drm_i915_display_funcs then
> gained a function pointer called init_clock_gating that intel_init_display
> sets to the appropriate function. However, there are some code paths, notably
> IS_PINEVIEW(dev), where init_clock_gating is not set and not needed. Calling
> it then fails. This patch fixes it by simply adding a null-pointer
> check.

Looks like Pineview should be using the gen3_init_clock_gating function.

-- 
keith.packard@xxxxxxxxx

Attachment: pgp00000.pgp
Description: PGP signature