Re: [GIT PULL] sound updates #2 for 2.6.40

[Takashi Iwai]

At Fri, 27 May 2011 19:44:54 -0700,
Linus Torvalds wrote:
> 
> On Fri, May 27, 2011 at 7:41 PM, Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Looking at that diff, I found at least one bug:
> >
> > - Â Â Â if (chip->driver_type != AZX_DRIVER_ATI &&
> > - Â Â Â Â Â chip->driver_type != AZX_DRIVER_ATIHDMI)
> > + Â Â Â if (chip->driver_caps & AZX_DCAPS_NO_TCSEL) {
> >
> > That's wrong. It should be
> >
> > Â Â Â Âif (!(chip->driver_caps & AZX_DCAPS_NO_TCSEL)) {
> >
> > but I haven't checked if that fixes it for me yet.
> 
> Yup, that's it. Apparently if you don't clear the TCSEL bit, you get
> random static and repeated stuff.
> 
> And the reason the conversion was wrong is that the bit is not a
> "feature" bit, it's a "lack of feature" bit, but the conversion missed
> the negation.

My bad.  I concentrated on fixing AMD issues, and this was a part of
it.  Obviously I didn't test Intel boxes carefully enough.

Sorry for taking your time!


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/