Re: [PATCH] mm: fix page_lock_anon_vma leaving mutex locked

[Linus Torvalds]

On Sat, May 28, 2011 at 4:24 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> That said, I do agree with the "anon_vma_root" part of your patch. I
> just think you mixed up two independent issues with it: the fact that
> we may be unlocking a new root, and the precise check used to
> determine whether the anon_vma might have changed.

Thinking some more about it, I end up agreeing with the whole patch.
The "page_mapped()" test is what we use in the slow-path after
incrementing the anon_vma count too when the trylock didn't work too,
so it can't be too wrong.

So I'm going to apply it as-is as an improvement (at least we won't be
unlocking the wrong anon_vma root), and hope that you and Peter end up
agreeing about what the sufficient test is for whether the anon_vma is
the right one.

                             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/