Re: [PATCH v2] arch/tile: add hypervisor-based character driver forSPI flash ROM

[Chris Metcalf]

On 5/28/2011 5:23 PM, Greg KH wrote:
> On Sat, May 28, 2011 at 11:13:54AM -0400, Chris Metcalf wrote:
>> + * This source code is derived from code provided in "Linux Device
>> + * Drivers" by Alessandro Rubini and Jonathan Corbet, published by
>> + * O'Reilly & Associates.
>> + */
> LDD version 2?  Wow, this driver is old.

The driver was originally written in 2007. LDD3 came out in 2005, right?  I
guess we were a little behind the curve :-)

>> +MODULE_LICENSE("Dual BSD/GPL");
> Wait, where did the BSD come from?  You just said it was GPL only above
> in the header of the file?

Good point.  We have a boiler-plate auto-generated GPL license comment that
we use for kernel sources.  In general, we've tended toward licenses that
are as available to the community as possible -- for example, the string
code that we've written is under GPL in the kernel (and glibc) but under a
BSD license in newlib, because we wrote it all from scratch and can do
that.  And, since we're hardware vendors, our general goal is to enable
whatever kinds of software will sell chips.  :-)

My guess is that we should be using a consistent GPL-only license for these
kinds of kernel drivers, because frankly, they aren't useful outside the
context of Linux.  I'll double-check with the rest of the software team,
but I think we should probably just switch this over to a straight "GPL"
license.

> As you are only using 1 minor device, why not just use a misc device
> instead?  It's simpler, and you get the sysfs code for free, which you
> forgot to do, so your device node will never show up in userspace :(

Interesting; this appears to be a bug.  We use 4 minors (see "srom_devs =
4" higher up).  I'll fix this.  We may have some other devices that would
benefit from being recast as misc devices, so I'll look at our set of
internal devices.

Is there a good example of a character device that has multiple minors and
also is registered with sysfs?

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/