Re: [PATCH] Firewire: net: replacing deprecated__attribute__((packed)) with __packed

[Stefan Richter]

On May 30 August Lilleaas wrote:
> On Sun, May 29, 2011 at 11:44 PM, Stefan Richter
> <stefanr@xxxxxxxxxxxxxxxxx>wrote:
> 
> > Who deprecated it and why?
> >
> 
> To be frank, the motivation for this patch was a message from script/
> checkpatch.pl when scouring random files for warnings. (This is my first
> contribution to the kernel.)
> 
> Just did some much needed investigation though. It was deprecated for
> portability, specifically to avoid GCC specific code. See commit
> 82ddcb040570411fc2d421d96b3e69711c670328.

OK, thanks for the info.

> > Shouldn't you add "#include <linux/compiler.h>" now?
> >
> 
> You're right. I'll read up on updating patches and get at it.

I will just add it when I commit the patch.

(One way to update a patch is to make it the top commit, then edit files
and "git add ..." them as necessary, then "git commit --amend".  There are
other ways of course.)
-- 
Stefan Richter
-=====-==-== -=-= ====-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/