Re: [PATCH 1/1] aat2870: Adding backlight, regulator and mfd driver

[Joe Perches]

On Mon, 2011-05-30 at 17:17 +0900, Jin Park wrote:
> Adding backlight, regulator and mfd driver for AnalogicTech AAT2870.
> Signed-off-by: Jin Park <jinyoungp@xxxxxxxxxx>

Hi Jin, just trivia

> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
[]
> +config MFD_AAT2870_CORE
> +	bool "Support for the AnlogicTech AAT2870"

Analogic

> +++ b/drivers/mfd/aat2870-core.c
[]
> +static struct aat2870_register aat2870_regs[AAT2870_REG_NUM] = {

Might describe this as the reg_cache as well.
readable, writable could be bool.

> +	/* readable, writeable, value */
> +	{ 0, 1, 0x00 },	/* 0x00 AAT2870_BL_CH_EN */

[]

> diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c
[]
> +static int aat2870_ldo_voltages[] = {

static const int?

> +	1200000, 1300000, 1500000, 1600000,
> +	1800000, 2000000, 2200000, 2500000,
> +	2600000, 2700000, 2800000, 2900000,
> +	3000000, 3100000, 3200000, 3300000,

[]

> diff --git a/include/linux/mfd/aat2870.h b/include/linux/mfd/aat2870.h
[]
> +/* Backlight current magnitude (mA) */
> +enum aat2870_current {
> +	AAT2870_CURRENT_0_45 = 0,

Seems odd and error prone to add enum = value
every 10 places.

> +	AAT2870_CURRENT_0_90,
> +	AAT2870_CURRENT_1_80,
> +	AAT2870_CURRENT_2_70,
> +	AAT2870_CURRENT_3_60,
> +	AAT2870_CURRENT_4_50,
> +	AAT2870_CURRENT_5_40,
> +	AAT2870_CURRENT_6_30,
> +	AAT2870_CURRENT_7_20,
> +	AAT2870_CURRENT_8_10,
> +	AAT2870_CURRENT_9_00 = 10,
[]
> +struct aat2870_register {
> +	int readable;
> +	int writeable;

bool?

> +struct aat2870_data {
> +	struct device *dev;
> +	struct i2c_client *client;
> +
> +	struct mutex io_lock;
> +	struct aat2870_register *reg_cache; /* register cache */
> +	int en_pin; /* enable GPIO pin (if < 0, ignore this value) */
> +	int is_enable;

bool?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/