Re: [PATCH] 8250_pci: add -ENODEV code for Intel EG20T PCH

[Greg KH]

On Mon, May 30, 2011 at 05:17:19PM +0900, Tomoya MORINAGA wrote:
> On Monday, May 30, 2011 4:47 PM,  Greg KH wrote:
> 
> > Why put this with an #if around it? 
> > Why not just always not 
> > bind to this driver as we have a "correct" driver for the 
> > hardware now?
> 
> Let me clarify your saying.
> Which does your saying mean,  (1) or (2) or else?
> 
> (1)
> > +#if defined(CONFIG_SERIAL_PCH_UART) || defined(CONFIG_SERIAL_PCH_UART_MODULE)
> > +		return -ENODEV;
> > +#endif
> 
> (2)
> > +	if ((dev->vendor == PCI_VENDOR_ID_INTEL && dev->device == 0x8811) ||
> > +	   (dev->vendor == PCI_VENDOR_ID_INTEL && dev->device == 0x8812) ||
> > +	   (dev->vendor == PCI_VENDOR_ID_INTEL && dev->device == 0x8813) ||
> > +	   (dev->vendor == PCI_VENDOR_ID_INTEL && dev->device == 0x8814) ||
> > +	   (dev->vendor == 0x10DB && dev->device == 0x8027) ||
> > +	   (dev->vendor == 0x10DB && dev->device == 0x8028) ||
> > +	   (dev->vendor == 0x10DB && dev->device == 0x8029) ||
> > +	   (dev->vendor == 0x10DB && dev->device == 0x800C) ||
> > +	   (dev->vendor == 0x10DB && dev->device == 0x800D))
> > +		return -ENODEV;

(2)

Just don't put the #if check in the .c file at all, and always compile
in the "quirk" table.

Even better yet, use the proper quirk table structure in the driver
already to cause the driver to not be bound to these devices, that's
what it is there for, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/